Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pre-commit / gh actions #18

Closed
4 tasks done
kaitj opened this issue Nov 3, 2022 · 0 comments · Fixed by #31
Closed
4 tasks done

Run pre-commit / gh actions #18

kaitj opened this issue Nov 3, 2022 · 0 comments · Fixed by #31
Assignees
Milestone

Comments

@kaitj
Copy link
Collaborator

kaitj commented Nov 3, 2022

The problem

From #16

We should run pre-commit run --all-files, maybe in a separate PR. There will be a lot of changes...

We should also double check that the GH actions check align with the pre-commit hooks, maybe in the same PR. I think if the checks pass pre-commit run --all-files shouldn't want to change anything.

To run following corrections to .smk files

  • pre-commit
  • poe quality (gh action)
    • add github action
  • Run quality and pre-commit

EDIT: Just realized there is no github action check...will add one in

Environment

N/A

@kaitj kaitj added this to the v0.1.0 milestone Nov 3, 2022
@kaitj kaitj mentioned this issue Nov 3, 2022
9 tasks
@kaitj kaitj linked a pull request Nov 4, 2022 that will close this issue
9 tasks
@kaitj kaitj self-assigned this Nov 4, 2022
@kaitj kaitj linked a pull request Nov 22, 2022 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant