-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question - Subtitle Support #203
Comments
Yes, if the media contains subtitles, they should show up. However, we only support a few subtitle formats, DVB subtitles and what TVHesdend calls TEXTSUB. It's possible were missing something used by IPTV streams (or it's possible TVH isn't passing it through). Do you have any details on the subtitle format used? |
I think you made a great point. I just realized when I connect Android Live Channels to my HDHR I get some extra informations from the Live Channels app. Information such as aspect ratio (16:9), subtitle (CC), video quality (FULL HD), audio quality (5.1) but when I tune to the same channel from THV Live Channels app, I only get video quality (FULL HD), audio quality (5.1). I tried using the Kodi PVR addon and I also didn't get subtitle. Only video and audio. As you suggested, TVHeadend either not passing it through or IPTV stream doesn't seem to carry that information. I need to figure out how to use the builtin passthrough profile (pass) as i haven't had much luck getting any tvh clients to work with it. I need to know which codecs are in the container. |
Okay. So I just did an easy test in vlc and I had subtitles using http://:5004/auto/v502 So it's either the protocol (HTSP) is not passing the subtitle or perhaps you guys are not asking for it. See picture below |
By any chance can you please take a look at the code and see if you guys are pulling every data being sent. Thanks. |
Could you grab some logs from your device as you change onto a channel you know has subtitles? Buried in the log will be a listing of each of the streams TVHeadend is sending us, and which ones we're ignoring because we don't understand them. Also.. what version of the app are you using? And what TVH version? https://github.com/kiall/android-tvheadend/wiki/ADB has some pointers on this. |
Server: HTS Tvheadend 4.3-210~g7644886-dirty I will send log shortly. |
Log file attached. Let me know if you need anything else |
Okay so I see what's going on. There is a difference between sub and closed captions. I had to do some reading and I am guessing the app does not support closed caption? |
The relevant parts of the logs are here, the first 5 lines being what we get from TVH, and the last 20 or so are what the video player component is seeing and handling:
Which basically says we received 1 MPEG2 video stream, and 2 AC3 audio tracks, all of which have been handled, and that no subtitle streams were found. I actually don't have any video sources that include captions embedded within the video track, so it's entirely possible I've not correctly implemented support for them! I'll see if I can find one.. Could you also try and create a muxdump and share it with me? That way I can look at the actual video stream you're having issues with. https://github.com/kiall/android-tvheadend/wiki/Muxdump Try to make sure you get a piece of video that actually includes captions! Often, adbreaks don't :) |
From memory, the aspect ratio is determined based on the video resolution, and it video's pixel aspect ratio. Re the sample - thanks, I can see this defiantly have some closed captions embedded:
I'll see if I can find why we're not picking them up |
Great. Thanks for spending your weekend looking into this. If you need anything else, please, don't hesitate to ask. Besides your wiki how-to guides are on point. |
And oh, If that is the case I don't get why the Aspect Ration with TVH Live Channels doesn't show. In the log it clearly states that it knows the resolution. Not a big deal as it doesn't break or prevent me from watching live tv. So far this app has been the most solid app I have used on Android TV for Live TV. But if you like I can create a new issue to track it. Let me know. The closed captions is more serious for me as I have some household member visiting from another country who doesn't fully understand english.
|
Yea, please do file an issue :) Include any detail you can (e.g. those logs and sample etc), I'll never remember to come looking over here again for them ;) |
So, it looks like ExoPlayer doesn't currently support CEA 607/708 inside MPEG2 aka H262 (Which is what I assume is in your sample, I haven't double checked that yet). |
Is Android TV Live Channels using a different player than the one you are using with this app? Or is the limitation on the stream encoder (mpeg2/h262) that is being passed to TVHeadend Lives Channels by TVHeadend server the problem? My confusion here is, if the stream is the same exact stream whether its from Android Live Channel HDHomerun Beta Tuner or TVHeadend Live Channels, it is still the stream with the same container and the same codecs. I am just a little confused. That's all. |
Each Live Channels plugin app provides their own video player, so this one vs the HDHomerun Beta Tuner will be different players. They'll both (eventually) hand off the separated video/audio/etc streams to your devices hardware decoders.. But a lot happens in the middle :) We make use of Google's ExoPlayer project, HDHomerun Beta Tuner probably uses something else which doesn't have a bug re detecting EIA/CEA-607/608 captions within H262 (aka MPEG2 video) streams. As near as I can tell, what TVHeadend is providing us does have the correct subtitles embedded within it, the problem is, we're (well - ExoPlayer, which we use) is not picking up on them. Hopefully that ExoPlayer bug will be resolved soon, and then they should start working in this app. |
Ha. That makes sense now. Perhaps VLC would have been a better player since it plays pretty much everything and anything. Ever a stream from the gods is playable by VLC :) Again, thanks for looking into this. |
We used to support VLC :) But, tying it into TVHeadend properly wad hard (e.g. DVR and timeshift was simply impossible without using TVH's custom protocol :()... and it resulted in all video decoding happening in software, rather than on the dedicated decoder hardware.. Which meant stuttering on lower power devices, or high bitrate channels (e.g. 4k). |
I see what you mean. In that case, great decision to move away from it. My playback with this app is butter. Specially after I enabled timeshift on the server end with 60 minutes buffer, ffmpeg on the client as well as passthrough. Right now I have no issues. CC would have been great but since it is not possible right now I won't cry wolf over it. I'll just let my guests know it's time to pack up their stuff and go back where they came from. Hopefully there she won't need any closed captions :D Clearly I don't share their troubles. |
Does this app currently support subtitles? I can switch audio but my subtitles option is always "off". I am currently using it the app with IPTV (HDHR Prime configured as m3u playlist) and HTSP streaming profile.
The text was updated successfully, but these errors were encountered: