Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the participant.phenotype field to a nested type #1956

Closed
6 of 8 tasks
jberube opened this issue Jul 22, 2019 · 1 comment
Closed
6 of 8 tasks

Change the participant.phenotype field to a nested type #1956

jberube opened this issue Jul 22, 2019 · 1 comment
Assignees
Labels
Epic [Type] Group Stories/Feature

Comments

@jberube
Copy link
Contributor

jberube commented Jul 22, 2019

Goal

We need to update the type of the following fields in graphql from object to nested to support and array of values instead of a single one:

  • participant.phenotype
  • participant.files.family.family_compositions.family_members
  • file.participants.phenotype
  • file.participants.family.family_compositions.family_members

See: kids-first/kf-es-model#48

Procedure

Preparation

Action

  • Publish the ETL in QA
  • ⚠️ From this point forward, there is a risk that QA will be unstable or broken
  • Make the change to the 4 phenotype fields to match the ES model using the upgraded admin-ui
  • Change the environment variable (locally or in QA) in kf-portal-ui to point to the new index's projectid (REACT_APP_PROJECT_ID)
  • ⚠️ From this point forward, there is a chance that QA will be stable again, but no guarantee. If not, proceed with More actions

More actions

  • See what breaks in portal-ui and fix it asap!
@jberube jberube self-assigned this Jul 22, 2019
@aalex
Copy link
Contributor

aalex commented Jul 24, 2019

(QA) It seems like searches with Phenotypes yield no more results in QA.

image

image

@jberube jberube added the Epic [Type] Group Stories/Feature label Jul 29, 2019
@jberube jberube closed this as completed Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic [Type] Group Stories/Feature
Projects
None yet
Development

No branches or pull requests

3 participants