Open access files should be accessible for everyone

[aalex]

Description

This bug touches two issues:

• The DCF file acl are not accounted for
• The open access files (acl = *) are not accounted for

Steps to reproduce

• Navigate to https://portal.kidsfirstdrc.org/file/GF_TFW9T293 - its ACL is set to * in the data service.
• The "Download" button should be enabled for every user, for that file.
• Instead, it is not. Also, note the "File is locked." message. It should not be there.

Note

Can only be reproduce on non-Gen3 files. Gen3 files should be properly available.

Can be reproduced on both Gen3 and DCF files when the file is open access.

Screenshot

Technical details

• This file should be have open Access ACL - meaning, they do not require the user to be granted permission to be able to download them.
• It seems like in services/fileAccessControl.js, the code looks up the contents of the acl field in the file-centric index.
• see src/components/EntityPage/File/index.js:413. Only GEN3 access are validated.

[aalex]

It might a config problem with the lambdas or the key manager.

[jberube]

The fix that was done was incomplete, as it only addressed a part of the issue, which was that DCF acl where not accounted for.

The second part is that "open access" files (acl = *) are not taken into account inside the FileEntity page.

To validate: the validation of the acl in the file repository page could also have the same bug.