Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details regarding the selected HPO term on the right side of the Sunburst's card #2640

Closed
2 of 3 tasks
denis-crsj opened this issue Aug 7, 2020 · 4 comments
Closed
2 of 3 tasks
Assignees
Milestone

Comments

@denis-crsj
Copy link
Contributor

denis-crsj commented Aug 7, 2020

Feature

We want to show some details about the selected HPO term on the right side of the graph/card. It should contain the following information and also look like the following screenshot:

  • HPO Term and ID/Number
  • Number of participants including descendants
  • Number of participants with the exact term

image

Acceptance Criteria

  1. The HPO term on the right represents the same HPO as the one selected in the Sunburst.
  2. The values for the number of participants are accurate
  3. Switching the term on the sunburst updates all values on the right (HPO term and number of participants)

Sub-Tasks

List of what needs to be done on the technical side.

  • Sub-task 1

Testing Strategy

What do we need to test? Who can test it? How do we test it? What do we need to test it?

Defects

List of defects/bugs found during QA.

  • The number in the center of the Sunburst, on the right of it and the number of participants on top don't match.
  • Based on the designs, the spacing between the HPO term and it's ID should be a bit larger. Also, we need to remove the ":" and just put a space instead.

Resources

Sunburst specs: https://www.notion.so/ferlab/KF-Ontology-Sunburst-212f8110b7794cbca44198a1ab7f993b

Figma designs: https://www.figma.com/file/0voQuoBD3Xvap4wYQ0VLYq/KF---Sunburst?node-id=151%3A0

@evans-g-crsj
Copy link
Contributor

image

@denis-crsj
Copy link
Contributor Author

denis-crsj commented Oct 29, 2020

@evans-g-crsj The different numbers on the page don't match and we'll need to figure out why before releasing it. J'ai ajouté le defect à la description avec un imprime-écran. Je vais remettre la carte dans "In progress" pour le moment.

@denis-crsj
Copy link
Contributor Author

Only one small defect added to the description.

@denis-crsj
Copy link
Contributor Author

all defects have been addressed, closing card

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants