Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a set in the Cohort Builder #2668

Closed
3 of 4 tasks
denis-crsj opened this issue Aug 17, 2020 · 2 comments
Closed
3 of 4 tasks

Using a set in the Cohort Builder #2668

denis-crsj opened this issue Aug 17, 2020 · 2 comments
Assignees
Milestone

Comments

@denis-crsj
Copy link
Contributor

denis-crsj commented Aug 17, 2020

Feature

We want users to be able to use their Saved sets in their queries in the Cohort Builder.

Acceptance Criteria

Scenario 1 (User has no Saved set)

  • Given: The user is on the Cohort Builder
  • Then: The "My Sets" filter is greyed out and unclickable

Scenario 2 (User has at least 1 Saved set)

  • Given: The user is on the Cohort Builder
  • When: The user clicks on the "My sets" filter, a modal open and lets the him choose which set he wants to add to his query
    • And: Once the user selects a set and clicks Submit
  • Then: The following term is added to the query "Participants ID in [name of Saved set]"

Sub-Tasks

List of what needs to be done on the technical side.

  • Sub-task ...

Testing Strategy

What do we need to test? Who can test it? How do we test it? What do we need to test it?

Defects

List of defects/bugs found during QA.

  • "Add To Query" button should be written "Add to query" with no capital letters except for the word "Add"
  • The colour of the button does not seem to be the right one. See the UI Kit for the right code for the green (Link below)
  • "Add to query" button should be disabled by default when no set is selected

Resources

https://www.notion.so/ferlab/Using-a-set-in-the-Cohort-Builder-848a37fb6cdc406297012aed10be4bde

https://www.figma.com/file/MKWJJXL7sz4poiIv5bKNtz/KF-UI-Kit-ant.design-v4-update?node-id=0%3A2368

@denis-crsj denis-crsj added this to the Sprint 20-03 milestone Aug 20, 2020
@denis-crsj denis-crsj modified the milestones: Sprint 20-03, Sprint 20-04 Sep 9, 2020
@denis-crsj denis-crsj added this to the Sprint 20-06 milestone Oct 1, 2020
@evans-g-crsj evans-g-crsj self-assigned this Oct 13, 2020
@denis-crsj
Copy link
Contributor Author

@evans-g-crsj 3 petits defects ont été ajoutés à la description plus haut. Je remet donc la carte dans "In progress"

@denis-crsj
Copy link
Contributor Author

All defects have been fixed, ready to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants