Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the participant.diagnosis_category field and adjust queries accordingly in the cohort builder #2818

Closed
vferretti opened this issue Nov 3, 2020 · 2 comments
Assignees
Labels
Bug [Type] Something isn't working ETL
Milestone

Comments

@vferretti
Copy link
Contributor

vferretti commented Nov 3, 2020

Currently we have 2 fields for diagnosis categories.

"participant_id":"PT_2EH6ZE0H",
 "diagnosis_category": null,
"diagnoses":[
    {    "diagnosis_category":"Cancer",
         "mondo_diagnosis": "Leukemia"
    }
]

This creates inconsistencies in the cohort builder. Example: https://portal.kidsfirstdrc.org/explore?id=61s

First step: Fix the query in the cohort builder
Second step: Remove the diagnosis_category field at the participant level at the ETL step

@evans-g-crsj evans-g-crsj added the To investigate [Status] Missing required technical information label Nov 13, 2020
@denis-crsj denis-crsj added this to the Sprint 20-09 milestone Nov 16, 2020
@evans-g-crsj
Copy link
Contributor

Minimally,

  • mapping must be changed (remove diagnosis_category)

  • The problem seems to be with participants having mondo diagnosis. That must be fixed + (remove filtering in portal UI)

@evans-g-crsj evans-g-crsj added the Blocked [Status] blocked label Nov 19, 2020
@denis-crsj denis-crsj added Bug [Type] Something isn't working and removed Defects labels Nov 27, 2020
@denis-crsj denis-crsj modified the milestones: Sprint 20-09, Sprint 20-10 Dec 14, 2020
@denis-crsj denis-crsj modified the milestones: Sprint 20-10, Sprint 21-01 Jan 8, 2021
@adipaul1981 adipaul1981 removed Blocked [Status] blocked To investigate [Status] Missing required technical information labels Jan 22, 2021
@denis-crsj
Copy link
Contributor

Validé avec Adrian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug [Type] Something isn't working ETL
Projects
None yet
Development

No branches or pull requests

4 participants