Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove Multicard component #3320

Open
evans-g-crsj opened this issue Jun 4, 2021 · 0 comments
Open

Refactor: remove Multicard component #3320

evans-g-crsj opened this issue Jun 4, 2021 · 0 comments
Assignees
@evans-g-crsj
Labels
- S - Estimated size of the task - Small Maintenance code/dependency maintenance tasks

Comments

@evans-g-crsj
Copy link
Contributor

This component src/uikit/Multicard/index.js seems to be dead code.

If that's the case, remove it.

It seems to be the only component that uses the library slick-carousel. So, most probably that this lib can be removed too.

Please make sure that components used inside that one that are only used there be removed too (IndexDots, TabMenu, css).
@evans-g-crsj evans-g-crsj added - S - Estimated size of the task - Small Maintenance code/dependency maintenance tasks labels Jun 4, 2021
@evans-g-crsj evans-g-crsj self-assigned this Jun 18, 2021
evans-g-crsj added a commit to evans-g-crsj/kf-portal-ui that referenced this issue Jun 18, 2021
@evans-g-crsj
refactor: kids-first#3320 remove unused multicard
1afce7e
evans-g-crsj added a commit that referenced this issue Jun 18, 2021
@evans-g-crsj
refactor: #3320 remove unused multicard (#3337)
c270ad1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evans-g-crsj evans-g-crsj

Labels
- S - Estimated size of the task - Small Maintenance code/dependency maintenance tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evans-g-crsj