Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve new lines in body and comments #72

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Jul 27, 2023

Thank you for submitting this pull request

fix (please add the issue ID if it exists)

Referenced pull requests

Checklist

  • Tests added if applicable.
  • Documentation updated if applicable.

Note: dist/cli/index.js and dist/gha/index.js are automatically generated by git hooks and gh workflows.

First time here?

This project follows git conventional commits pattern, therefore the commits should have the following format:

<type>(<optional scope>): <subject>
empty separator line
<optional body>
empty separator line
<optional footer>

Where the type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]

NOTE: if you are still in a work in progress branch and you want to push your changes remotely, consider adding --no-verify for both commit and push, e.g., git push origin <feat-branch> --no-verify - this could become useful to push changes where there are still tests failures. Once the pull request is ready, please amend the commit and force-push it to keep following the adopted git commit standard.

How to prepare for a new release?

There is no need to manually update package.json version and CHANGELOG.md information. This process has been automated in Prepare Release Github workflow.

Therefore whenever enough changes are merged into the main branch, one of the maintainers will trigger this workflow that will automatically update version and changelog based on the commits on the git tree.

More details can be found in package release section of the README.

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
88.13% (+0.03% 🔼)
349/396
🟢 Branches 81.82% 126/154
🟢 Functions
86.11% (+0.13% 🔼)
93/108
🟢 Lines
88.05% (+0.03% 🔼)
339/385

Test suite run success

127 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 461a2e4

@lampajr lampajr merged commit fa43ffc into kiegroup:main Jul 27, 2023
4 checks passed
@lampajr lampajr deleted the fix_body_newlines branch July 27, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant