-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: namespace parsing in gitlab #84
Conversation
Coverage report
Test suite run success159 tests passing in 16 suites. Report generated by 🧪jest coverage report action from a3814cb |
Thanks a lot for this contribution @shyim ! Going to take a look at this asap 🚀 |
Hey @shyim , the change looks great to me. After that, unfortunately I do not have any real nested scenario to test against, so if you have your concrete example I would appreciate if you can run the cmd line tool against your own nested repo to check if that works as expected - you can just |
Hey, I have tested it works great. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks again @shyim for your contribution ❤️
Could you maybe tag a new version? I would like to integrate it in our pipeline ❤️ |
Here it is https://github.com/kiegroup/git-backporting/releases/tag/v4.4.1 and https://www.npmjs.com/package/@kie/git-backporting/v/4.4.1 |
Thank you for submitting this pull request
URLs like
https://gitlab.shopware.com/shopware/6/product/commercial/-/merge_requests/1645
cannot be parsed right now as the extractor expects only one path in "namespace". But we have in our org nested stuff
Referenced pull requests
Checklist
First time here?
This project follows git conventional commits pattern, therefore the commits should have the following format:
Where the type must be one of
[build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]
How to prepare for a new release?
There is no need to manually update
package.json
version andCHANGELOG.md
information. This process has been automated in Prepare Release Github workflow.Therefore whenever enough changes are merged into the
main
branch, one of the maintainers will trigger this workflow that will automatically updateversion
andchangelog
based on the commits on the git tree.More details can be found in package release section of the README.