Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: namespace parsing in gitlab #84

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

shyim
Copy link
Contributor

@shyim shyim commented Dec 4, 2023

Thank you for submitting this pull request

URLs like https://gitlab.shopware.com/shopware/6/product/commercial/-/merge_requests/1645
cannot be parsed right now as the extractor expects only one path in "namespace". But we have in our org nested stuff

Referenced pull requests

Checklist

  • Tests added if applicable.
  • Documentation updated if applicable.

Note: dist/cli/index.js and dist/gha/index.js are automatically generated by git hooks and gh workflows.

First time here?

This project follows git conventional commits pattern, therefore the commits should have the following format:

<type>(<optional scope>): <subject>
empty separator line
<optional body>
empty separator line
<optional footer>

Where the type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]

NOTE: if you are still in a work in progress branch and you want to push your changes remotely, consider adding --no-verify for both commit and push, e.g., git push origin <feat-branch> --no-verify - this could become useful to push changes where there are still tests failures. Once the pull request is ready, please amend the commit and force-push it to keep following the adopted git commit standard.

How to prepare for a new release?

There is no need to manually update package.json version and CHANGELOG.md information. This process has been automated in Prepare Release Github workflow.

Therefore whenever enough changes are merged into the main branch, one of the maintainers will trigger this workflow that will automatically update version and changelog based on the commits on the git tree.

More details can be found in package release section of the README.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
90.05% (+0.14% 🔼)
389/432
🟢 Branches 83.06% 152/183
🟢 Functions 88.5% 100/113
🟢 Lines
90% (+0.12% 🔼)
378/420

Test suite run success

159 tests passing in 16 suites.

Report generated by 🧪jest coverage report action from a3814cb

@lampajr lampajr self-requested a review December 4, 2023 13:04
@lampajr
Copy link
Member

lampajr commented Dec 4, 2023

Thanks a lot for this contribution @shyim !

Going to take a look at this asap 🚀

@lampajr
Copy link
Member

lampajr commented Dec 4, 2023

Hey @shyim , the change looks great to me.
I just added a simple test to ensure the result is the expected one, do you mind to double check it: a3814cb ?

After that, unfortunately I do not have any real nested scenario to test against, so if you have your concrete example I would appreciate if you can run the cmd line tool against your own nested repo to check if that works as expected - you can just npm run compile and then call the cmd line tool (maybe you already did that :) ).

@shyim
Copy link
Contributor Author

shyim commented Dec 5, 2023

Hey,

I have tested it works great. 👍

Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks again @shyim for your contribution ❤️

@lampajr lampajr merged commit ed32d22 into kiegroup:main Dec 5, 2023
4 checks passed
@shyim shyim deleted the fix-gitlab-url-parsing branch December 5, 2023 15:15
@shyim
Copy link
Contributor Author

shyim commented Dec 5, 2023

Could you maybe tag a new version? I would like to integrate it in our pipeline ❤️

@lampajr
Copy link
Member

lampajr commented Dec 5, 2023

Could you maybe tag a new version? I would like to integrate it in our pipeline ❤️

Here it is https://github.com/kiegroup/git-backporting/releases/tag/v4.4.1 and https://www.npmjs.com/package/@kie/git-backporting/v/4.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants