fix: --auth when --git-user contains space #95
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since --git-user is a user-facing name, it's common to include a space in it. As such, it's not suitable to use as a username in a Git remote URL.
GitLab documented that it doesn't (yet?) check for username [1], and from my testing GitHub doesn't seem to care either. So just use an arbitrary name as a username.
[1] https://docs.gitlab.com/ee/user/profile/personal_access_tokens.html
Thank you for submitting this pull request
Checklist
First time here?
This project follows git conventional commits pattern, therefore the commits should have the following format:
Where the type must be one of
[build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]
How to prepare for a new release?
There is no need to manually update
package.json
version andCHANGELOG.md
information. This process has been automated in Prepare Release Github workflow.Therefore whenever enough changes are merged into the
main
branch, one of the maintainers will trigger this workflow that will automatically updateversion
andchangelog
based on the commits on the git tree.More details can be found in package release section of the README.