Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu: enable keyboard interaction and improve semantics #3703

Merged
merged 38 commits into from
Dec 12, 2024
Merged

Menu: enable keyboard interaction and improve semantics #3703

merged 38 commits into from
Dec 12, 2024

Conversation

Fuzzy3
Copy link
Collaborator

@Fuzzy3 Fuzzy3 commented Nov 12, 2024 •
edited
Loading

Which issue does this PR close?

This PR closes #3682

What is the new behavior?

Introducing keyboard support for kirby-menu with extended aria-attributes enabling disabled users using a screen reader with the keyboard to interact with a kirby-menu.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@Fuzzy3 Fuzzy3 requested a review from jkaltoft as a code owner November 12, 2024 13:45
@Fuzzy3 Fuzzy3 linked an issue Nov 12, 2024 that may be closed by this pull request
[Enhancement] A11y improvements for Menu #3682
Closed
14 tasks
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu November 12, 2024 13:51 Inactive
@RasmusKjeldgaard @jakobe @Fuzzy3
Calendar: enable keyboard interaction and improve semantics (#3689)
3cc2138 
Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu November 12, 2024 14:09 Inactive
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu November 12, 2024 14:48 Inactive
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu November 12, 2024 14:59 Inactive
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu November 12, 2024 15:08 Inactive
Fuzzy3
Fuzzy3 commented Nov 12, 2024
View reviewed changes
libs/designsystem/item/src/item.component.ts Outdated Show resolved Hide resolved
libs/designsystem/item/src/item.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
apps/cookbook/src/app/examples/menu-example/examples/advanced.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu November 20, 2024 13:44 Inactive
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu November 20, 2024 14:03 Inactive
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu November 20, 2024 14:19 Inactive
jakobe
jakobe reviewed Nov 21, 2024
View reviewed changes
libs/designsystem/menu/src/menu.component.html Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.html Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu November 21, 2024 18:59 Inactive
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu December 6, 2024 05:45 Inactive
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu December 6, 2024 05:54 Inactive
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu December 6, 2024 05:55 Inactive
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu December 6, 2024 06:21 Inactive
jakobe
jakobe reviewed Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@jakobe jakobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice changes and refactorings! 👌🏻 👏🏻

libs/designsystem/menu/src/menu.component.spec.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
RasmusKjeldgaard
RasmusKjeldgaard reviewed Dec 6, 2024
View reviewed changes
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
@Fuzzy3 Fuzzy3 changed the title Keyboard support at a11y enhancement for kirby menu Menu: enable keyboard interaction and improve semantics Dec 9, 2024
@Fuzzy3 Fuzzy3 enabled auto-merge (squash) December 9, 2024 05:09
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu December 9, 2024 05:10 Inactive
jakobe
jakobe reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@jakobe jakobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 👌🏻 👏🏻

libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
libs/designsystem/menu/src/menu.component.ts Outdated Show resolved Hide resolved
RasmusKjeldgaard and others added 3 commits December 11, 2024 11:29
@RasmusKjeldgaard @jakobe @Fuzzy3
Modal, Alert: label modal with title contents (#3702)
13c9fbb 
Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
Co-authored-by: Søren Oest Balmer <oestbalmer@gmail.com>
@jakobe @RasmusKjeldgaard @Fuzzy3
Item: improve styling for slotted textual content (#3734)
08db4ba 
Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
@Fuzzy3
merge
9786288
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu December 11, 2024 13:29 Inactive
Fuzzy3 and others added 3 commits December 12, 2024 09:46
@Fuzzy3 @jakobe
Update libs/designsystem/menu/src/menu.component.ts
5e1be2d 
Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
@Fuzzy3 @jakobe
Update libs/designsystem/menu/src/menu.component.ts
7e82ae7 
Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
@Fuzzy3 @jakobe
Update libs/designsystem/menu/src/menu.component.ts
e3170bd 
Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu December 12, 2024 08:51 Inactive
@github-actions github-actions bot temporarily deployed to pr-3682-enhancement-a11y-improvements-for-menu December 12, 2024 08:51 Inactive
jakobe
jakobe approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@jakobe jakobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Fuzzy3 Fuzzy3 merged commit 66190b4 into develop Dec 12, 2024
12 checks passed
@Fuzzy3 Fuzzy3 deleted the 3682-enhancement-a11y-improvements-for-menu branch December 12, 2024 11:43
@Fuzzy3 Fuzzy3 restored the 3682-enhancement-a11y-improvements-for-menu branch December 19, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusKjeldgaard RasmusKjeldgaard RasmusKjeldgaard left review comments

@jakobe jakobe jakobe approved these changes

@jkaltoft jkaltoft Awaiting requested review from jkaltoft jkaltoft is a code owner

Assignees
No one assigned
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] A11y improvements for Menu
3 participants
@Fuzzy3 @jakobe @RasmusKjeldgaard