Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with cmark-gfm-0.29.0.gfm.13 #345

Merged
1 commit merged into from
Sep 30, 2023

Conversation

digitalmoksha
Copy link
Collaborator

@digitalmoksha digitalmoksha commented Sep 30, 2023

Syncs with cmark-gfm version 0.29.0.gfm.13.

There were no functional changes, just a tweak to some nomenclature related to github/cmark-gfm#273. While the src/scanners.re was updated, this was just the internal variable name. I verified by running make src/scanners.rs, there were no changes generated for src/scanners.rs

@digitalmoksha
Copy link
Collaborator Author

cmark-gfm code diff is github/cmark-gfm@0.29.0.gfm.12...0.29.0.gfm.13

@digitalmoksha
Copy link
Collaborator Author

/run_bench

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

@ghost ghost merged commit 8dd49a8 into kivikakk:main Sep 30, 2023
12 of 13 checks passed
@ghost
Copy link

ghost commented Sep 30, 2023

/run_bench

I think this is still affected by #339.

@digitalmoksha
Copy link
Collaborator Author

/run_bench

I think this is still affected by #339.

I know, for some reason I just wanted to try it 😄

@digitalmoksha
Copy link
Collaborator Author

@charlottia would you consider publishing a new version of the crate?

@ghost
Copy link

ghost commented Oct 3, 2023

Sure thing, @digitalmoksha.

@ghost
Copy link

ghost commented Oct 3, 2023

That's done: https://crates.io/crates/comrak/0.19.0.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant