Add support for width in html output #362
Conversation
|
Hi there! Thank you for your work here. Unfortunately I will not accept this PR — I think it would be considered very surprising that setting The existing Line 488 in 315a25c In general, styling of the result is left to the end-user, since everyone will want something different. Someone else might want or assume that Comrak's scope is converting CommonMark to a given output format; things that are completely outside of that scope should be left out of it. Seeing as there is no provision in CommonMark itself to e.g. add a document title (such as would appear in a In other words, if you want such a header and footer, and if you want to apply a (The existing width option only applies to CommonMark output since there's no other way to reliably wrap such output without involving a CommonMark processor. If we ported upstream's plaintext/LaTeX/manpage modes, they'd also honour it.) Here's a shell script which produces output like you want using Comrak. The benefit is that you don't need a new release every time you want to change the styles. #!/usr/bin/env sh
body_tag="<body>"
if test -n "$WIDTH"; then
body_tag="<body style=\"width: $WIDTH%; margin: auto;\">"
fi
cat <<HTML
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
</head>
$body_tag
$(comrak "$@")
</body>
</html>
HTMLYou can invoke it like Comrak regularly, except if the |
|
I thought after making the PR Thanks for the very detailled answer ! |
Hello,
Here is a tiny PR to add
--widthsupport in HTML