Return brackets in autolinks behavior back to cmark-gfm #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
digitalmoksha
commented
Apr 28, 2024
Comment on lines
+193
to
+196
| // Allow any number of matching parentheses (as recognised in copen/cclose) | ||
| // at the end of the URL. If there is a greater number of closing | ||
| // parentheses than opening ones, we remove one character from the end of | ||
| // the link. |
There was a problem hiding this comment.
Hope it was ok to add this from the original C code.
There was a problem hiding this comment.
As the author of the original text, I deem it so 🙏
Run on Sun Apr 28 18:12:31 UTC 2024 |
|
@kivikakk wdyt? |
kivikakk
approved these changes
Apr 29, 2024
Comment on lines
+193
to
+196
| // Allow any number of matching parentheses (as recognised in copen/cclose) | ||
| // at the end of the URL. If there is a greater number of closing | ||
| // parentheses than opening ones, we remove one character from the end of | ||
| // the link. |
There was a problem hiding this comment.
As the author of the original text, I deem it so 🙏
When `relaxed-autolinks` is specified, allow only balanced brackets/curly braces in autolink.
kivikakk
force-pushed
the
bw-fix-autolink-brackets
branch
from
d6da25a
to
a842fe9
Compare
|
@kivikakk would it be possible to get a new release cut? |
|
It's on the way! :) |
|
Done. |
|
👍 🙇 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return brackets in autolinks behavior back to what is found in
cmark-gfmWhen
relaxed-autolinksis specified, also allow balanced brackets/curly braces in autolink, in addition to the standard parentheses. This also helps with detection of autolinks in[[...]]Related to #382