Async remote method always returns null

[madeleinedaly]

I'm trying to follow the instructions in the README for defining a remote method that returns a promise, but my client code (in Emacs) only ever receives null after calling that method. And that null appears to be returned synchronously, before the async task in my remote method actually resolves a real value to return.

I created a failing test case for this issue here: madeleinedaly@525b722

[madeleinedaly]

It turns out that returning a native promise from a remote method won't pass the instanceof check here:

node-elrpc/lib/elrpc.js

Line 423 in e5f87df

if (ret instanceof Promise) {

My test above passes if I return a bluebird promise from the remote method. I wonder if it's worth updating the docs to specify that bluebird must be used? Or we could use something like https://github.com/sindresorhus/p-is-promise instead of instanceof to allow either native or bluebird promises in the caller. I'd be happy to contribute the latter change as a PR.

[kiwanami]

Thank you for your nice report. I merged your PR.

Yes. I also think that this project should remove bluebird as a polyfill of ES6 Promise...

[madeleinedaly]

Thanks for this set of libraries! It has opened a new world of possibilities for me.