Fixed legitimate issues found with linting

kiwi-cam · Jun 21, 2021 · 9a78ce4 · 9a78ce4
1 parent ab8dcf0
commit 9a78ce4
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 12 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -44,7 +44,6 @@
         "dot-notation": "warn",
         "no-autofix/prefer-const": "warn",
 
-
         "indent": ["error", 2, { "SwitchCase": 1 }],
         "linebreak-style": ["error", "unix"],
         "curly": 1

diff --git a/accessories/fan.js b/accessories/fan.js
@@ -60,7 +60,7 @@ class FanAccessory extends SwitchAccessory {
 
   async checkAutoOff() {
     await catchDelayCancelError(async () => {
-      const { config, log, name, state, serviceManager } = this;
+      const { config, log, logLevel, name, state, serviceManager } = this;
       let { disableAutomaticOff, enableAutoOff, onDuration } = config;
 
       if (state.switchState && enableAutoOff) {
@@ -76,7 +76,7 @@ class FanAccessory extends SwitchAccessory {
 
   async checkAutoOn() {
     await catchDelayCancelError(async () => {
-      const { config, log, name, state, serviceManager } = this;
+      const { config, log, logLevel, name, state, serviceManager } = this;
       let { disableAutomaticOn, enableAutoOn, offDuration } = config;
 
       if (!state.switchState && enableAutoOn) {

diff --git a/accessories/heater-cooler.js b/accessories/heater-cooler.js
@@ -297,7 +297,7 @@ class HeaterCoolerAccessory extends BroadlinkRMAccessory {
         }
         // do not change state of fanspeed mode
         if (keys.includes('fanSpeedDnd')) {
-          return decodeHierarchichalHex(hexDataObject['fanSpeedDnd'], checkCharacteristics, toUpdateCharacteristic)
+          return this.decodeHierarchichalHex(hexDataObject['fanSpeedDnd'], checkCharacteristics, toUpdateCharacteristic)
         }
         if (keys.includes(keyFromState)) {
           return this.decodeHierarchichalHex(hexDataObject[keyFromState], checkCharacteristics, toUpdateCharacteristic)
@@ -749,7 +749,7 @@ class HeaterCoolerAccessory extends BroadlinkRMAccessory {
   }
 
   async checkTemperatureForAutoOnOff(temperature) {
-    const { config, host, log, name, serviceManager, state } = this;
+    const { config, host, log, logLevel, name, serviceManager, state } = this;
     let { autoHeatTemperature, autoCoolTemperature, minimumAutoOnOffDuration } = config;
 
     if (this.shouldIgnoreAutoOnOff) {

diff --git a/accessories/learnCode.js b/accessories/learnCode.js
@@ -62,8 +62,7 @@ class LearnIRAccessory extends BroadlinkRMAccessory {
       bind: this,
       props: {
 
-      },
-      bind: this
+      }
     })
   }
 }

diff --git a/accessories/switchMultiRepeat.js b/accessories/switchMultiRepeat.js
@@ -65,7 +65,7 @@ class SwitchMultiAccessory extends SwitchAccessory {
           await this.pauseTimeoutPromise;
         } else if (index < data.length - 1) {
           this.intervalTimeoutPromise = delayForDuration(interval);
-          await intervalTimeoutPromise;
+          await this.intervalTimeoutPromise;
         }
       }
 

diff --git a/base/accessory.js b/base/accessory.js
@@ -42,11 +42,11 @@ class HomebridgeAccessory {
   }
 
   setDefaults() {
-    if(config.allowResend === undefined){
-      if(config.preventResendHex === undefined){
-        config.allowResend = true;
+    if (this.config.allowResend === undefined) {
+      if (this.config.preventResendHex === undefined) {
+        this.config.allowResend = true;
       } else {
-        config.allowResend = !config.preventResendHex;
+        this.config.allowResend = !this.config.preventResendHex;
       }
     }
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -62,8 +62,7 @@ class LearnIRAccessory extends BroadlinkRMAccessory { @@
           bind: this,
           props: {
-          },
-          bind: this
+          }
         })
       }
     }
@@ Expand Down @@