Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto download without message or with :x or :wq #118

Closed
singledoggy opened this issue Jun 3, 2024 · 3 comments · Fixed by #120
Closed

auto download without message or with :x or :wq #118

singledoggy opened this issue Jun 3, 2024 · 3 comments · Fixed by #120
Labels
bug Something isn't working enhancement New feature or request

Comments

@singledoggy
Copy link

Is your feature request related to a problem? Please describe.
When I enable auto-download, it doesn't work if I use :x or :wq to quit. It seems to be triggered only by the :w command. Additionally, if I use some external scripts to execute :w every few seconds, I receive too many messages.

Describe the solution you'd like
Is there any way to disable the messages or add a trigger for the :wq or :x commands?

@singledoggy singledoggy added the enhancement New feature or request label Jun 3, 2024
@kiyoon kiyoon added the bug Something isn't working label Jun 3, 2024
@kiyoon
Copy link
Owner

kiyoon commented Jun 3, 2024

Hi, thanks for reporting!

I'll add an option to disable the download message.

I didn't know it didn't download on :wq. I'll need to debug this issue and then I'll let you know. It's likely that the buffer gets detached before calling BufWritePre event. Which platform are you using?

@singledoggy
Copy link
Author

TL;DR : This issue is caused by my Vim configuration, not a bug with your plugin.

Hi, thank you for your prompt reply. Based on your response, I investigated my ini.vim configuration file and found that some of my settings were causing other buffers to close automatically when I closed the main buffer. This is because certain plugins output syntax check information in new buffers, which becomes irrelevant once the main file is closed.

Since I didn't see any messages, I mistakenly thought that the download was not successful.

@kiyoon
Copy link
Owner

kiyoon commented Jun 4, 2024

@singledoggy Thanks for the update! It indeed helps me :) Then I'll just focus on adding the option to disable the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants