-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking manual validation #216
Comments
has_undercoordinated_alkali_alkalineflagged 26 compounds manually opened all. I would like a tool flags all those cases to me - all seem suspicious. Some are very off, e.g. RSM2843 |
has_lone_moleculeflags (145) many compounds Manual inspection reveals many Ag-N compounds, which look "strange" in the ball-stick-view in VESTA (this is probably also often due to charge issues, e.g. RSM0929 or RSM0092 - in latter, it would have been also easy to find out from the original file in the CSD as there is perchlorate. Also DUWRIY misses a charge. RSM0456 is also wrong - the CSD entry has a charged carboxy in the linker). Overall, there might be some false positives but all structures I opened were not trivially correct to me on first glance. |
The RSM folder contains 3400 structures maybe and flagging around 10% of the structures is still good right ? |
well, I have only manually checked two types of checks so far. If you look at all flags there are 447 in 3152 I ran this on. And "good" and "bad" is in the eye of the beholder :) |
Ohhh I see. Let me then help with the rest and see what we get |
Manually identified charged MOFs
|
Ran the current master on the RSM MOFs.
The text was updated successfully, but these errors were encountered: