Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: paragraph spacing #53

Closed
2 tasks done
tracker1 opened this issue Aug 21, 2021 · 7 comments
Closed
2 tasks done

[Feat]: paragraph spacing #53

tracker1 opened this issue Aug 21, 2021 · 7 comments
Assignees

Comments

@tracker1
Copy link

Detailed Description

Don't have time for a PR at the moment, appended to my local copy, but probably a good idea to add..

p + p {
  margin-top: 1rem;
}

Contributing

  • I have read the project's contribution guidelines.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Anything else?

No response

@tracker1 tracker1 assigned ghost Aug 21, 2021
@ghost ghost added code labels Aug 22, 2021
@gouravmohanty7070
Copy link
Contributor

I would love to solve the issue if anyone isn't working on it currently!

@ghost
Copy link

ghost commented Aug 27, 2021

Ya sure @gouravmohanty7070!

@ghost ghost assigned gouravmohanty7070 and unassigned ghost Aug 27, 2021
@ghost
Copy link

ghost commented Aug 27, 2021

Here is a step by step guide

  • Add the code mentioned in the issue to src/scss/global.scss

  • Copy the content of src/scss/global.scss to src/less/global.less

  • Add this code to src/sass/global.sass

    p + p
      margin-top: 1rem
  • Copy the contents of src/sass/global.sass to src/styl/global.styl

  • Build the code, you are done 🎉

@Narcos101
Copy link

is @gouravmohanty7070 still on it? And can I work on it?

@gouravmohanty7070
Copy link
Contributor

@Narcos101 Yes bro! I got this issue today itself. I am working on it

@gouravmohanty7070
Copy link
Contributor

@krishdevdb aren't the code mentioned in the issue and the code to be copied in sis/sass/global.css same?
So, it means the same line of code is to be added in both global.sass and global.scss?

@ghost
Copy link

ghost commented Aug 28, 2021

Thanks for the contributions @tracker1 and @gouravmohanty7070! Don't worry @Narcos101 we have another issue for ya #37

@ghost ghost closed this as completed Aug 28, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants