feat(composed-arbitrable): implement

[epiqueras]

Closes #126

[0xferit]

Couldn't spot a serious flaw.

[0xferit]

Build is failing because of #121 , I would rebase onto master branch and force push but in case you don't want it I'm leaving as is.

[epiqueras]

I doubt the compiler optimizes like that. If it does, `a = true` would be the same as `a = a || true`, because it would see `a === true` and it wouldn't write.

…

On Sun, Oct 7, 2018 at 11:18 AM Ferit Tunçer ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In contracts/standard/arbitration/composed-arbitrable/fee/MultiPartyInsurableFees.sol <#129 (comment)> : > + fundDisputeCache.refundedValue = msg.value - fundDisputeCache.keptValue; + if (fundDisputeCache.keptValue > 0) { + _paidFees.totalValue[_paidFees.totalValue.length - 1] += fundDisputeCache.keptValue; + _paidFees.totalContributedPerSide[_paidFees.totalContributedPerSide.length - 1][_side] += fundDisputeCache.keptValue; + _paidFees.contributions[_paidFees.contributions.length - 1][msg.sender][_side] += fundDisputeCache.keptValue; + } + if (fundDisputeCache.refundedValue > 0) msg.sender.transfer(fundDisputeCache.refundedValue); + emit Contribution(_agreementID, _paidFees.stake.length - 1, msg.sender, fundDisputeCache.keptValue); + + // Check if enough funds have been gathered and act accordingly. + if ( + _paidFees.totalContributedPerSide[_paidFees.totalContributedPerSide.length - 1][_side] >= fundDisputeCache.requiredValueForSide || + (fundDisputeCache.appealing && !fundDisputeCache.appealPeriodSupported) + ) { + if (_side == 0 && !(fundDisputeCache.appealing && !fundDisputeCache.appealPeriodSupported)) { // Losing side and not direct appeal. + if (!_paidFees.loserFullyFunded[_paidFees.loserFullyFunded.length - 1]) Hmm. Do you think that the following is equivalent gas-wise? _paidFees.loserFullyFunded[_paidFees.loserFullyFunded.length - 1] = _paidFees.loserFullyFunded[_paidFees.loserFullyFunded.length - 1] || true; — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#129 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASRQaKT2s8hx4yGxf8bMMhPltD-lHLsFks5uiilVgaJpZM4W5Nc5> .