Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RW To Model coercion does not work on subclasses #225

Closed
pauxus opened this issue Mar 22, 2022 · 0 comments
Closed

RW To Model coercion does not work on subclasses #225

pauxus opened this issue Mar 22, 2022 · 0 comments
Labels
LHF Low hanging fruit
Milestone
1.2

Comments

@pauxus
Copy link
Member

pauxus commented Mar 22, 2022

in #89 we included coercion, but we only check for equality. This should also check if the given argument is a superclass of the model
@pauxus pauxus added the LHF Low hanging fruit label Mar 22, 2022
@pauxus pauxus added this to the 1.2 milestone Mar 22, 2022
@pauxus pauxus closed this as completed in 428ea54 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LHF Low hanging fruit
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
1 participant
@pauxus