media upload cleanup bug

[gabriel-vasile]

listmonk/cmd/media.go

Lines 62 to 85 in a440b79

	fName, err = app.media.Put(fName, contentType, src)
	if err != nil {
	app.log.Printf("error uploading file: %v", err)
	cleanUp = true
	return echo.NewHTTPError(http.StatusInternalServerError,
	app.i18n.Ts("media.errorUploading", "error", err.Error()))
	}
	var (
	thumbfName = ""
	width = 0
	height = 0
	)
	defer func() {
	// If any of the subroutines in this function fail,
	// the uploaded image should be removed.
	if cleanUp {
	app.media.Delete(fName)
	if thumbfName != "" {
	app.media.Delete(thumbfName)
	}
	}
	}()

when err != nil in this code there should be cleanup done, but the cleanup function has not been yet deferred.

[knadh]

Ah, removed that redundant flag. That error happens when the file upload itself has failed, in which case, there's no file to cleanup.