Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

[consolidated] Update channel's status.subscribers based on the dispatcher propagated consumer readiness #280

Closed
devguyio opened this issue Dec 16, 2020 · 2 comments

Comments

@devguyio
Copy link
Contributor

Problem
The solution that was proposed in #182 did not fix the problem of adding the subscriptions to the channel only when the corresponding consumer in the dispatcher is ready and due to a lag in Sarama between the consumer group creation and starting the consumer, it seems there's no other way than to propagate the consumer readiness from the dispatcher

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
3d

Additional context (optional)
#134
#98
knative/eventing-contrib#1556
#182

@devguyio devguyio changed the title [consolidated] Update channel's status.subscriber based on the dispatcher propagated consumer readiness [consolidated] Update channel's status.subscribers based on the dispatcher propagated consumer readiness Dec 16, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2021
@devguyio
Copy link
Contributor Author

Fixed by #433

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 23, 2021
@devguyio devguyio closed this as completed Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant