Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated VirtualService contains wrong gateways field #44

Closed
yanniszark opened this issue Mar 13, 2020 · 0 comments · Fixed by #43
Closed

Generated VirtualService contains wrong gateways field #44

yanniszark opened this issue Mar 13, 2020 · 0 comments · Fixed by #43

Comments

@yanniszark
Copy link
Contributor

The gateways field of the VirtualService CRD indicates to which Istio
Gateways this VirtualService applies to.

At the moment, all configured gateways of are added to the gateways fields.
However, if the user wants to only specify a local gateway, they also
get the public gateway in that field.

This confuses the reconciler, which can't find the gateway and errors out.
The VirtualService generation logic should instead only add gateways which are actually used by the VirtualService routes.

Related code: https://github.com/knative/net-istio/blob/f08de598438b0e85c27b401416575405cc451eba/pkg/reconciler/ingress/resources/virtual_service.go#L135-L140
Related issue: #43
/cc @tcnghia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant