Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for providing sink spec in GVR format #1704

Closed
vyasgun opened this issue Jul 17, 2022 · 0 comments · Fixed by #1717 or #1724
Closed

Add support for providing sink spec in GVR format #1704

vyasgun opened this issue Jul 17, 2022 · 0 comments · Fixed by #1717 or #1724
Assignees
Milestone

Comments

@vyasgun
Copy link
Contributor

vyasgun commented Jul 17, 2022

Feature request

The user can specify a sink in subscription create and update (--sink, --sink-reply, --sink-dead-letter flags), source create and update(--sink flag), and broker create and update (--dl-sink flag). Currently, only a few known types are supported as an argument to these flags ("broker", "ksvc", and "channel"). If the user provides any other prefix outside the supported ones, kn returns an unsupported sink prefix error.

Use case

To use sinks of custom types.

UI Example

kn source ping create my-ping --schedule "*/2 * * * *" --data '{ value: "hello" }' --sink <apiVersion>:<kind>:<name>:<namespace>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment