Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Kafka source - comma or array for servers and topics #1055

Closed
duglin opened this issue Mar 23, 2020 · 6 comments · Fixed by #1156
Closed

Kafka source - comma or array for servers and topics #1055

duglin opened this issue Mar 23, 2020 · 6 comments · Fixed by #1156

Comments

@duglin
Copy link

duglin commented Mar 23, 2020

Problem

Today, for the Kafka event source, when people specify the list of bootstrap servers or topics, they're comma separated lists. When these lists get long (e.g. I'm messing with a usecase with ~100 topics), I'm wondering if a real array wouldn't be easier for people to manage. And for consistency, I have the same question for the list of bootstrap servers.

Persona:

Event consumer

@matzew
Copy link
Member

matzew commented Mar 31, 2020

yeah, sounds good !

/cc @lionelvillard

@lionelvillard
Copy link
Member

@aslom

@aslom
Copy link
Member

aslom commented Apr 8, 2020

Is there a way to make it backward compatible? Supporting both string (for comma separated list) and array of strings?

@aslom
Copy link
Member

aslom commented Apr 8, 2020

Most popular configuration in Java Kafka application properties uses comma separated list: "bootstrap.servers: A list of host/port pairs to use for establishing the initial connection to the Kafka cluster. "

http://kafka.apache.org/documentation/#consumerconfigs
https://jaceklaskowski.gitbooks.io/apache-kafka/kafka-properties-bootstrap-servers.html

@duglin
Copy link
Author

duglin commented Apr 8, 2020

it should be easy to support both, but might look kind of funky. If the "normal" flow is to use a comma for some of these then ok. It just felt odd as I was playing with it - and I was adding over a 100 entries :-)

I was thinking about the case where the yaml is in git and if someone changes something the "diff" will just show the entire long line and it might be hard to detect what changed. As separate lines it becomes easier.

@lberk
Copy link
Member

lberk commented Apr 20, 2020

/assign

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants