Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Delete Receiver Adapter deployment when sink is not found #1493

Closed
itsmurugappan opened this issue Aug 20, 2020 · 5 comments · Fixed by #1533
Closed

Delete Receiver Adapter deployment when sink is not found #1493

itsmurugappan opened this issue Aug 20, 2020 · 5 comments · Fixed by #1533
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature-request source/kafka Kafka source related issue

Comments

@itsmurugappan
Copy link
Contributor

itsmurugappan commented Aug 20, 2020

Problem
Create a kafka source before creating the ksvc(which is the sink), kafka source wont create a deployment, this works as expected. But, after succesful reconciliation of kafka source, if ksvc is deleted, kafka source status goes to false, but pod is still up, trying to send messages to sink.

In this scenario if we delete the deployment of receiver adapter, it will be reconciled back when the sink is back up.

Persona:
Developer

Exit Criteria
Kafka source adapter deployment is deleted when sink is not found

Additional context (optional)
I tried these step manually and it works fine.

@grantr grantr added the source/kafka Kafka source related issue label Aug 20, 2020
@grantr
Copy link
Contributor

grantr commented Aug 20, 2020

I think I would classify this as a bug:

if ksvc is deleted, kafka source status goes to false, but pod is still up, trying to send messages to sink.

IIUC, the messages the receive adapter tries to send are not retried if the sink comes back, but are lost during the downtime.

@grantr grantr added the kind/bug Categorizes issue or PR as related to a bug. label Aug 20, 2020
@itsmurugappan
Copy link
Contributor Author

yes, messages are lost.

@itsmurugappan
Copy link
Contributor Author

@grantr can i send a PR to address this one or it needs more discussion ?

@grantr
Copy link
Contributor

grantr commented Sep 3, 2020

@itsmurugappan Yes please do send a PR! If you plan to work on this issue, please assign it to yourself so nobody else duplicates your work. Use the /assign command in a comment.

@itsmurugappan
Copy link
Contributor Author

/assign

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature-request source/kafka Kafka source related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants