Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries for webhook failures. #3952

Closed
vaikas opened this issue Aug 27, 2020 · 2 comments · Fixed by #4045
Closed

Add retries for webhook failures. #3952

vaikas opened this issue Aug 27, 2020 · 2 comments · Fixed by #4045
Assignees
Labels
area/test-and-release Test infrastructure, tests or release kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor.
Milestone

Comments

@vaikas
Copy link
Contributor

vaikas commented Aug 27, 2020

Describe the bug

While looking at this CI failure:
https://prow.knative.dev/view/gcs/knative-prow/logs/ci-knative-eventing-continuous/1299057320398950401

=== CONT  TestBrokerV1Beta1ControlPlane/InMemoryChannel-messaging.knative.dev/v1/Ready_Trigger_V1Beta1_(no_Broker)_set_Broker_and_includes_status.subscriber_Uri
    broker_control_plane_test_helper.go:140: Error: Could not get trigger trigger-no-broker: conversion webhook for eventing.knative.dev/v1, Kind=Trigger failed: Post https://eventing-webhook.knative-eventing-xhyd6284y5.svc:443/resource-conversion?timeout=30s: EOF
=== CONT  TestBrokerV1Beta1DataPlaneConsumer
    creation.go:288: Failed to create v1beta1 trigger "transform-trigger": Internal error occurred: failed calling webhook "webhook.eventing.knative.dev": Post https://eventing-webhook.knative-eventing-xhyd6284y5.svc:443/defaulting?timeout=2s: EOF
=== RUN   TestBrokerV1Beta1ControlPlane/InMemoryChannel-messaging.knative.dev/v1/Ready_Trigger_V1Beta1_includes_status.subscriber_Uri

We should probably add retries here (and other places in these helpers):
https://github.com/knative/eventing/blob/master/test/conformance/helpers/broker_control_plane_test_helper.go#L138

Kind of like this:
https://github.com/knative/eventing/blob/master/test/lib/creation.go#L124

Or use these libraries instead of calling directly to the kubernetes api?

A clear and concise description of what the bug is.

Expected behavior
A clear and concise description of what you expected to happen.

To Reproduce
Steps to reproduce the behavior.

Knative release version

Additional context
Add any other context about the problem here such as proposed priority

@vaikas vaikas added kind/bug Categorizes issue or PR as related to a bug. area/test-and-release Test infrastructure, tests or release kind/good-first-issue Denotes an issue ready for a new contributor. labels Aug 27, 2020
@lberk lberk added this to the v0.18.0 milestone Aug 31, 2020
@aliok
Copy link
Member

aliok commented Sep 9, 2020

/assign

@slinkydeveloper
Copy link
Contributor

@vaikas some of these failures may be connected to failing webhook-certs knative/pkg#1641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-and-release Test infrastructure, tests or release kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants