Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt health checks in sharedmain #1048

Closed
pmorie opened this issue Feb 4, 2020 · 6 comments · Fixed by knative/serving#13563
Closed

Adopt health checks in sharedmain #1048

pmorie opened this issue Feb 4, 2020 · 6 comments · Fixed by knative/serving#13563
Labels
kind/feature lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@pmorie
Copy link
Member

pmorie commented Feb 4, 2020

Currently, we do not use health checks in our controllers descended from sharedmain. Adopting health checks will allow us to begin reporting controllers as unhealthy so that they are restarted by the kubelet. For example, we will be able to use the leaderelection health checker to begin reporting unhealthy after the leader election timeout elapsed when renewing the leader election lease.

/kind feature

Expected Behavior

Controllers can report themselves as unhealthy so that they can be restarted.

Actual Behavior

That doesn't happen.

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@afrittoli
Copy link
Contributor

afrittoli commented Oct 20, 2020

/open

@afrittoli
Copy link
Contributor

/lifecycle frozen

@knative-prow-robot knative-prow-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 20, 2020
@mattmoor mattmoor reopened this Oct 20, 2020
@mattmoor
Copy link
Member

We should use the shared drainer logic, but probably have something that does this over HTTP (no need for TLS)

@mpetason
Copy link
Contributor

/assign

I'll take a shot at this.

@mpetason mpetason removed their assignment Jan 25, 2021
@mpetason
Copy link
Contributor

Unassigned so someone can resolve this faster than I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants