Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Knative Prow into a GitHub app #2962

Closed
chizhg opened this issue Dec 9, 2021 · 5 comments
Closed

Convert Knative Prow into a GitHub app #2962

chizhg opened this issue Dec 9, 2021 · 5 comments
Assignees

Comments

@chizhg
Copy link
Member

chizhg commented Dec 9, 2021

As the number of repos in Knative grows, there'll be issues in authenticating to the GitHub APIs with the GitHub Personal Access Token, since the rate limit is always 5000 per hour. To make it more scalable and secure, it'll be nice to convert Knative Prow into a GitHub app.

After it's converted into a GitHub app, the Prow jobs for peribolos, label_sync and branchprotector should also be switched to authenticate as GitHub app, to bypass the token rate limit.

More contexts in https://docs.google.com/document/d/1q9NagH0xB2vcuK-TC_X6V_LHc0syBrNrLqiuAQ8zGWY/edit#heading=h.66y4kqbj468a

@chizhg
Copy link
Member Author

chizhg commented Mar 25, 2022

/assign

@chizhg
Copy link
Member Author

chizhg commented Mar 28, 2022

Followed the documentations to manually apply the changes and manually did the test. Confirmed the migration has been successful.

Below are the PRs needed for the migration:

@chizhg
Copy link
Member Author

chizhg commented Mar 29, 2022

One more fix for the GitHub ops Prow jobs:

@chizhg
Copy link
Member Author

chizhg commented Mar 29, 2022

The migration has been done. Marking this issue as fixed.

@chizhg chizhg closed this as completed Mar 29, 2022
@chizhg chizhg moved this from Needs Design to In Progress in Infra (Productivity) Apr 1, 2022
@chizhg chizhg self-assigned this Apr 1, 2022
@chizhg chizhg moved this from In Progress to Done in Infra (Productivity) Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants