Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shtool a dependency, drop sudo in boostrap.sh #156

Open
vanrein opened this issue May 31, 2022 · 0 comments
Open

Make shtool a dependency, drop sudo in boostrap.sh #156

vanrein opened this issue May 31, 2022 · 0 comments

Comments

@vanrein
Copy link

vanrein commented May 31, 2022

I tried bootstrapping ksmppd and got a mild shock when it wanted to use sudo. This is not what you want scripts to do, unless you really make install -- it's a security loophole.

A workaround might be to install it in a subdirectory. But I found that treating shtool-dev as a dependency and commenting out the dangerous code also works. And it's not so wild to require dependencies.

Maybe a suggestion to make your code friendlier on new users who are exploring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant