Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSI updates- add bip 39 generation, expose DID generation on header file #135

Closed
fkim7 opened this issue May 25, 2023 · 7 comments · Fixed by #137
Closed

SSI updates- add bip 39 generation, expose DID generation on header file #135

fkim7 opened this issue May 25, 2023 · 7 comments · Fixed by #137
Assignees
Labels
enhancement New feature or request

Comments

@fkim7
Copy link
Collaborator

fkim7 commented May 25, 2023

part of https://github.com/knox-networks/dart-sdk/issues/62 realized some functions arent exposed in the SSI FFI header file.

Gaps identified so far

  • bip 39 generation
  • DID generation
  • VC download
  • Wallet association

Until this is sorted out, Yan is going straight grpc

@LuisOsta LuisOsta added the enhancement New feature or request label Jun 12, 2023
@LuisOsta
Copy link
Contributor

@fkim7 Currently SSI doesn't support

  • Getting VCs from credential adapter
  • Wallet Association for user-mgmt

So we'd have to add that functionality here if we wanted to abstract that away for clients. Would we want add that functionality to SSI? @fkim7 @yanctrindade I'm curious to hear what the benefit is to handle it here vs in Dart. I'm not necessarily against it just curious to hear about what the benefits are.

The rest I think are FFI issues that I'll investigate

@fkim7
Copy link
Collaborator Author

fkim7 commented Jun 12, 2023

The idea was that the SSI would be a 1 stop shop for identity, so you just use this 1 SDK for everything identity related and save work for the developers to generate their own SDKs off the protos.. I was looking at the SSI SDK as a generic Knox identity SDK in Rust that can FFI into several languages and save dev time.

@LuisOsta
Copy link
Contributor

Okay sounds good

@LuisOsta
Copy link
Contributor

LuisOsta commented Jun 13, 2023

@fkim7 @yanctrindade For context "DID generation" is already exposed via create_identity and registry_create_did. If that's not the needed functionality let me know what exactly you mean by that

@LuisOsta
Copy link
Contributor

LuisOsta commented Jun 15, 2023

I've created #139 to handle the VC download side of things

@fkim7
Copy link
Collaborator Author

fkim7 commented Jun 15, 2023

lets create link account/associate wallet also

@yanctrindade
Copy link

@LuisOsta the new KeyParir Struct expose the mnemonic but DidDocument has the DID after create_identity is not accessible since we dont have DidDocument struct exposed on ssi_ffi.h, something else we can do is create a fuction passing the didDocument pointer that returns the pointer.char to did generated. Idk the pros and cons from each approach.

The thing is, If I use only SSI lib I have following use cases

  1. generate bip39 mnemonic and access the 12 words string
  2. Create identity (DidDocumento struct)
  3. registry the identity created (push did doc)

but If I want to access the did itself its not exposed from ssi_ffi.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants