Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a coding style checker and enforce it #36

Closed
curry684 opened this issue Aug 19, 2016 · 3 comments
Closed

Add a coding style checker and enforce it #36

curry684 opened this issue Aug 19, 2016 · 3 comments

Comments

@curry684
Copy link
Contributor

Adding a .php_cs file would make the project more consistent internally, I noticed a lot of missing comments, long array notation et al.

(I'll be happy to do this if asked but it's commonly considered maintainer's task and privilege to set and enforce standards).

@weaverryan
Copy link
Member

Hi @curry684!

I would warmly welcome this, and would love if you would add it - I don't often use a cs fixer (and so don't know much about the .php_cs files), but it does make a lot of sense for OS projects, and I love the automation of such things. We should probably just base our file off of Symfony's https://github.com/symfony/symfony/blob/master/.php_cs

Cheers!

@curry684
Copy link
Contributor Author

The Symfony one is actually far too specialized and custom given their use of generated code et al, I'll whip up a simple one from one of my other projects.

@curry684
Copy link
Contributor Author

Closed by #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants