Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customizing link style with any color sets fill property to black instead of none #416

Closed
g3o2 opened this issue Nov 26, 2016 · 4 comments
Closed

customizing link style with any color sets fill property to black instead of none #416

g3o2 opened this issue Nov 26, 2016 · 4 comments
Labels
Status: Approved Is ready to be worked on

Comments

@g3o2
Copy link

g3o2 commented Nov 26, 2016

example code

graph TB;
    A-->B;
    linkStyle 0 stroke:red;
    B-->C;
    C-->A;

http://knsv.github.io/mermaid/live_editor/#/edit/Z3JhcGggVEI7CiAgICBBLS0-QjsKICAgIGxpbmtTdHlsZSAwIHN0cm9rZTpyZWQ7CiAgICBCLS0-QzsKICAgIEMtLT5BOw
@g3o2 g3o2 mentioned this issue Nov 26, 2016
Closed
@knsv
Copy link
Collaborator

knsv commented Nov 27, 2016 •
edited
Loading

I agree! Fill noen definitely looks better... :) This should be fixed. It should be fairly straight forward.

@joshuacolvin
Copy link
Contributor

I can help with this.

@knsv knsv added Status: Approved Is ready to be worked on and removed Contributor needed labels Jan 9, 2017
@knsv
Copy link
Collaborator

knsv commented Jan 9, 2017

That is appreciated!

knsv added a commit that referenced this issue Jan 9, 2017
@knsv
Merge pull request #452 from joshuacolvin/issue416_link_style_fill_none
cac960c 
Fix for #416, customizing link style with any color sets `fill` property to `black` instead of `none`
@knsv
Copy link
Collaborator

knsv commented Jan 29, 2017

Closed by release 7.0.0, please reopen if issues remain.

@knsv knsv closed this as completed Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Approved Is ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@knsv @joshuacolvin @g3o2