Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't catch parse error Maximum call stack size exceeded on safari #421

Closed
kaqiling opened this issue Nov 29, 2016 · 3 comments
Closed

can't catch parse error Maximum call stack size exceeded on safari #421

kaqiling opened this issue Nov 29, 2016 · 3 comments

Comments

@kaqiling
Copy link

kaqiling commented Nov 29, 2016

Hi, I'm using mermaid, but I find a problem in https://github.com/knsv/mermaid/blob/master/src/mermaidAPI.js#L291. When flowchart contains a Chinese symbol like ';' or '《' , Chrome will catch Maximum call stack size exceeded, but Safari will call recursively and comsume memory endlessly, and I can't do anything on Safari.

@kaqiling
Copy link
Author

kaqiling commented Jan 9, 2017

Please paste code like

graph LR
A--》B

in http://knsv.github.io/mermaid/live_editor/ in safari browser.
I use mermaid in Mac OS x WebView, the bug is also produced in my application. And chrome is ok.
If someone input Chinese symbol like '《' by a mistake, we should tell him or her invalid syntax instead of doing noting and let the application unresponsive.

@kaqiling
Copy link
Author

kaqiling commented Jan 9, 2017

also for #405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants