Allow end as a substring of vertex id
#224
Merged
+42
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jison adds \b (word boundary) to literal string patterns by default. It does so, because it doesn't follow traditional match-longest approach, but does match-first instead. Without including word boundaries, it'd be hard to distinguish between a keyword and identifier. The pattern for `end` keyword is not a simple string literal - it swallows trailing whitespace, so we have to add \b manually. This partially fixes mermaid-js#184 - at least now `end` behaves the same as other keywords: it can be used as a prefix and infix, but not as a suffix. To solve this issue completely, ALPHA pattern would have to match multiple letters, which is a much bigger change.
knsv
added a commit
that referenced
this pull request
Oct 15, 2015
Allow `end` as a substring of vertex id
|
Thanks, much appreciated! This issue was bugging me. |
This was referenced Jul 9, 2020
This was referenced Aug 16, 2020
This was referenced Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jison adds \b (word boundary) to literal string patterns by default.
It does so, because it doesn't follow traditional match-longest
approach, but does match-first instead. Without including word
boundaries, it'd be hard to distinguish between a keyword and
identifier.
The pattern for
endkeyword is not a simple string literal - itswallows trailing whitespace, so we have to add \b manually.
This partially fixes #184 - at least now
endbehaves the same as otherkeywords: it can be used as a prefix and infix, but not as a suffix.
To solve this issue completely, ALPHA pattern would have to match
multiple letters, which is a much bigger change.