Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkStyle now supports list of indexes with a few tests #798

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

ivan-danilov
Copy link
Contributor

For example:
linkStyle 0,1,2 interpolate basis stroke:#00f,stroke-width:2px;

Other variants of linkStyle syntax are also included

For example:
linkStyle 0,1,2 interpolate basis stroke:#00f,stroke-width:2px;

Other variants of linkStyle syntax are also included
@coveralls
Copy link

Pull Request Test Coverage Report for Build 739

  • 43 of 48 (89.58%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 54.324%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/diagrams/flowchart/parser/flow.js 31 36 86.11%
Files with Coverage Reduction New Missed Lines %
src/diagrams/flowchart/parser/flow.js 1 62.04%
Totals Coverage Status
Change from base Build 716: 0.07%
Covered Lines: 2058
Relevant Lines: 3762

💛 - Coveralls

ivan-danilov added a commit to ivan-danilov/hugo-theme-docdock that referenced this pull request Feb 21, 2019
…kStyle in a single line

See mermaid-js/mermaid#798

Also, added an example to the exampleSite
@ivan-danilov
Copy link
Contributor Author

Am I supposed to address codeclimate's issues? Most of them are about the code auto-generated from jison, a couple is about similarities in test code (indeed the code pieces are similar when they test similar situations), and one is Function updateLink has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. To me updateLink looks fine.

I couldn't find contribution guide or something, so could you please advice what should I do next?

@knsv
Copy link
Collaborator

knsv commented Jun 11, 2019

Thank you Ivan! I agree, we need to think about the codeclimate tests. If you still want to do something, consider adding some diagrams with this styling in the e2e tests. That will make sure the fix is not lost at some point in the future.

@knsv knsv merged commit 752a12b into mermaid-js:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants