Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon sizes needs put sizing back? #2298

Closed
yangwao opened this issue Feb 9, 2022 · 7 comments
Closed

Icon sizes needs put sizing back? #2298

yangwao opened this issue Feb 9, 2022 · 7 comments
Labels

Comments

@yangwao
Copy link
Member

yangwao commented Feb 9, 2022

That one time I've skipped skip netlify builds :D

I guess the recent update fontawesome-svg-core made this change #2294

check https://beta.kodadot.xyz/rmrk/collection/160a6f4320f11acb25-LCKWV

image

@yangwao yangwao added $ ~<50usd p1 preventing everyone from using app 🧙‍♀️ - bug-hunt css labels Feb 9, 2022
@kkukelka
Copy link
Member

kkukelka commented Feb 9, 2022

I'll take a look

@yangwao
Copy link
Member Author

yangwao commented Feb 9, 2022

@kkukelka
Copy link
Member

kkukelka commented Feb 9, 2022

We've used this back then

https://github.com/vue-polkadot/apps/blob/develop/dashboard/src/main.ts#L30

i'm losing my mind over here.
Screenshot 2022-02-09 at 16 53 35
something in bulma config just straight up overwrites is-small class

reverted all relevant changes (package.json, scss stuff) from past week but cant seem to find issue

@roiLeo
Copy link
Contributor

roiLeo commented Feb 9, 2022

Don't know if these could help but I noticed that we missed the .fa-w- class on svg
With old packages we have same bug, I've tried to move icons to plugins and changed the config, same thing happened.

@kkukelka
Copy link
Member

kkukelka commented Feb 9, 2022

Don't know if these could help but I noticed that we missed the .fa-w- class on svg With old packages we have same bug, I've tried to move icons to plugins and changed the config, same thing happened.

ah indeed , still exists on production
Screenshot 2022-02-09 at 18 10 32

@kkukelka
Copy link
Member

kkukelka commented Feb 9, 2022

related to FortAwesome/Font-Awesome#18654

@yangwao
Copy link
Member Author

yangwao commented Feb 9, 2022

I've reverted it in a7b424c

@yangwao yangwao added p5 ideas for future and removed p1 preventing everyone from using app labels Feb 9, 2022
@yangwao yangwao closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants