Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getting rid some warning messages #11246

Merged
merged 4 commits into from
Dec 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion components/shared/AudioMedia.vue
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
</template>

<script lang="ts" setup>
import { ref, watch, withDefaults } from 'vue'
import { useElementHover, watchDebounced } from '@vueuse/core'
import { NeoImageMedia } from '@kodadot1/brick'
Expand Down
9 changes: 6 additions & 3 deletions components/shared/modals/ModalWrapper.vue
Original file line number Diff line number Diff line change
Expand Up @@ -45,19 +45,22 @@ import { NeoButton, NeoModal } from '@kodadot1/brick'
const props = withDefaults(
defineProps<{
label: string
label?: string
title: string
icon: string
type?: string
expanded: boolean
isRight: boolean
expanded?: boolean
isRight?: boolean
id: string
isButtonHidden: boolean
}>(),
{
label: undefined,
type: undefined,
id: '',
isButtonHidden: false,
isRight: false,
expanded: false,
},
)
Expand Down
2 changes: 0 additions & 2 deletions libs/ui/src/components/MediaItem/type/ImageMedia.vue
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@
</template>

<script lang="ts" setup>
import { computed, withDefaults } from 'vue'
import TheImage from '../../TheImage/TheImage.vue'
import type {
ImageComponent,
Expand Down
4 changes: 1 addition & 3 deletions libs/ui/src/components/TheImage/TheImage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ import type {
ConcreteComponent,
ImgHTMLAttributes,
MethodOptions,
ReservedProps,
} from 'vue'
import { computed, withDefaults } from 'vue'
export type ImageComponent =
| 'img'
Expand All @@ -22,7 +20,7 @@ export type ImageComponent =
| string
export type ImageComponentProps = Record<string, unknown>
interface Props extends /* @vue-ignore */ ImgHTMLAttributes, ReservedProps {
interface Props extends /* @vue-ignore */ ImgHTMLAttributes {
imageComponent?: ImageComponent
imageComponentProps?: ImageComponentProps
}
Expand Down
3 changes: 3 additions & 0 deletions nuxt.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,15 @@ export default defineNuxtConfig({
'date-fns/formatDistanceToNow',
'keen-slider/vue',
'lodash/camelCase',
'lodash/chunk',
'lodash/filter',
'lodash/groupBy',
'lodash/isEqual',
'lodash/orderBy',
'lodash/sortBy',
'lodash/sum',
'lodash/unionBy',
'lodash/uniqBy',
'lodash/zipWith',
'markdown-it',
'partysocket',
Expand All @@ -84,6 +86,7 @@ export default defineNuxtConfig({
'lodash',
'jdenticon',
'gql.tada',
'viem',
'viem/chains',
'@web3modal/wagmi/vue',
'@wagmi/core',
Expand Down
7 changes: 6 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"@polkadot/ui-settings": "^3.6.6",
"@polkadot/util": "^12.6.2",
"@polkadot/util-crypto": "^12.6.2",
"@polkadot/vue-identicon": "^3.6.6",
"@polkadot/vue-identicon": "^3.11.3",
"@ramp-network/ramp-instant-sdk": "^4.0.5",
"@tanstack/vue-query": "^5.56.2",
"@transak/transak-sdk": "^1.4.1",
Expand Down Expand Up @@ -148,5 +148,10 @@
},
"resolutions": {
"@apollo/federation": "0.38.1"
},
"pnpm": {
"patchedDependencies": {
"@polkadot/vue-identicon@3.11.3": "patches/@polkadot__vue-identicon@3.11.3.patch"
}
}
}
13 changes: 13 additions & 0 deletions patches/@polkadot__vue-identicon@3.11.3.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/Identicon.js b/Identicon.js
index 18ac195b5fd0adfe10aa1e69ef5715e32be3ad2d..24f446e967cd089c930a405503aacb4021238370 100644
--- a/Identicon.js
+++ b/Identicon.js
@@ -97,7 +97,7 @@ export const Identicon = defineComponent({
key: address,
size: iconSize
})
- }, []);
+ }, () => []);
}
else {
return h(cmp, {}, []);
Loading
Loading