Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify RajaOngkir API Call #1

Merged
merged 3 commits into from
Oct 1, 2021
Merged

refactor: simplify RajaOngkir API Call #1

merged 3 commits into from
Oct 1, 2021

Conversation

axmad386
Copy link
Member

@axmad386 axmad386 commented Oct 1, 2021

Refactor Code

This PR is include refactor and fixing typo.
I add function apiCall to simplify for making request to rajaongkir API. Please add comment if something is not working or need change. Thank you

Changes:

  • refactor: simplify switching base_url based on account type and api call
  • test: config test

@sangvictim sangvictim merged commit 243fb30 into main Oct 1, 2021
@sangvictim sangvictim deleted the refactor branch October 1, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants