Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send Ctrl+C does not work on Windows 8.1 #58

Closed
segrey opened this issue Nov 12, 2018 · 3 comments
Closed

Send Ctrl+C does not work on Windows 8.1 #58

segrey opened this issue Nov 12, 2018 · 3 comments
Labels
bug

Comments

@segrey
Copy link
Contributor

segrey commented Nov 12, 2018 •
edited
Loading

Windows 8.1 Pro

When running manually:
image

When running via Java API:

Exception in thread "main" org.jvnet.winp.WinpException: External Ctrl+C execution failed for process pid=1160. Ctrl+C process exited with code -1073741515: Failed to attach to the console (see the AttachConsole WinAPI call). error=0 at winp.cpp:59
	at org.jvnet.winp.Native.sendCtrlC(Native Method)
	at org.jvnet.winp.Native.sendCtrlC(Native.java:90)
	at org.jvnet.winp.WinProcess.sendCtrlC(WinProcess.java:93)
	at example.Main.main(Main.java:29)

See example project to reproduce: stop-child-process.zip.
@segrey segrey changed the title Send Ctrl+C does not work on Windows 8 Send Ctrl+C does not work on Windows 8.1 Nov 12, 2018
@oleg-nenashev
Copy link
Member

So it will require MVS redist to be installed. https://answers.microsoft.com/en-us/windows/forum/windows_10-windows_install-winpc/msvcr120dll-missing/ef3bca56-3155-4383-ac99-d2a6ea262831

It is a usual issue in MVS projects unfortunately, needs a fix ASAP

segrey added a commit to segrey/winp that referenced this issue Nov 20, 2018
@segrey
generate code without runtime dependency on DLL (Fixes jenkinsci#58)
19b473a 
Additionally, update toolset to v140. Current toolset (v120) is not available for Visual Studio 17 and the only way is to install VC++ 2013 which is inconvenient. (https://social.msdn.microsoft.com/Forums/windows/en-US/07ce397a-611b-4233-99b7-4b4bf6f58589/is-there-a-way-to-install-platform-toolset-v120-on-visual-studio-2017)
@segrey
Copy link
Contributor Author

segrey commented Nov 27, 2018

Suggested fix: PR #59

@segrey
Copy link
Contributor Author

segrey commented Nov 29, 2018 •
edited
Loading

Also affects Windows 10 installations on Mac with Boot Camp. Looks like MSVCR120.dll is missing there as well. Reported as https://youtrack.jetbrains.com/issue/WEB-36095

oleg-nenashev added a commit that referenced this issue Dec 8, 2018
@oleg-nenashev
Merge pull request #59 from segrey/code-generation-without-dll
cbf2093 
generate code without runtime dependency on DLL (Fixes #58)
SergeyZh pushed a commit to JetBrains/intellij-community that referenced this issue Feb 25, 2019
@segrey
update winp to 1.28 (IDEA-202408, WEB-36921, WEB-36095)
4066dac 
Changes:
* No flickering console window when sending Ctrl+C (jenkinsci/winp#60)
* Support sending Ctrl+C on Windows 8.1 (jenkinsci/winp#58)
SergeyZh pushed a commit to JetBrains/intellij-community that referenced this issue Feb 25, 2019
@segrey
IDEA-CR-43994: update winp to 1.28 (IDEA-202408, WEB-36921, WEB-36095)
3856724 
Changes:
* No flickering console window when sending Ctrl+C (jenkinsci/winp#60)
* Support sending Ctrl+C on Windows 8.1 (jenkinsci/winp#58)

(cherry picked from commit 4066dac)
SergeyZh pushed a commit to JetBrains/intellij-community that referenced this issue Apr 10, 2019
@segrey
node: use winp always to terminal Windows processes softly (jenkinsci…
2b98787 
…/winp#58)
intellij-monorepo-bot pushed a commit to JetBrains/intellij-community that referenced this issue Mar 26, 2022
@segrey @zolotov
node: use winp always to terminal Windows processes softly (jenkinsci…
a6abb20 
…/winp#58)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@segrey @oleg-nenashev