Provide system property to not unpack dlls' into parent dir

[os97673]

In our (Idea) case we do not want Winp to unpack dlls in parent dir because we may not have access to it, thus we have added a new property to control this behavior.

[oleg-nenashev]

// previous conversation is available in #11
The PR LGTM

[os97673]

@kohsuke do I need to do anything else to improve the patch?

[oleg-nenashev]

If there's no response from @kohsuke, I'll merge and release changes on the next week.

P.S/Off-topic:
I would start documenting system properties somewhere. There is a public Javadoc at http://winp.kohsuke.org/apidocs/index.html, but Javadoc is not so flexible as Doxygen. It would be great to have a specific annotation and a processor to generate documentation pages (especially for Jenkins Wiki)

[os97673]

It would be nice to have a released version of the library (with the PR merged) before March ;)

[oleg-nenashev]

New Year weeks are too long :(
I also discovered that I have no access to winp.
I'll ping @kohsuke on the Jenkins governance meeting tomorrow (if it happens)

[os97673]

thanks

[oleg-nenashev]

Updated Jenkins meeting agenda: https://wiki.jenkins-ci.org/display/JENKINS/Governance+Meeting+Agenda#GovernanceMeetingAgenda-Jan21meeting%28%3F%29

[os97673]

Thank you. When we can expect a new version of the library with the changes included?

[oleg-nenashev]

Created https://github.com/kohsuke/winp/releases/tag/1.23-beta
The build process have been migrated to the new Visual Studio version, so it would be great to perform some tests before the release

[os97673]

Agree. Testing is good :) Do you need any help?

[oleg-nenashev]

Currently I'm waiting for https://issues.sonatype.org/browse/OSSRH-13404 to be able to release the library. ETA - beginning of the next week.

My test app works well on 64-bit Win7 host. It frequently terminates windows processes, so I suppose the 64-bit configuration has been migrated correctly. Hopefully I'll find some time to try Jenkins on other OS and 32-bit platforms as well.

I could also try to patch TeamCity (I suppose it and IDEA use the same integration layer), but actually I would prefer to leave such steps to JetBrains.

[os97673]

TeamCity doesn't use winp, so it looks like there is no need to change anything there.

[oleg-nenashev]

I see it in %BUILD_AGENT_ROOT%\tools\idea\lib on Windows agents (version 1.21-patched). Probably, TeamCity takes it from IDEA components :)

I got all required permissions, hence I can release the library at any moment.
There're too much verification efforts for a small patch. I'll have to start working on #15 at some point, so it's better to have a test environment.

[os97673]

I see it in %BUILD_AGENT_ROOT%\tools\idea\lib on Windows agents (version 1.21-patched). Probably, TeamCity takes it from IDEA components :)

it is just the library Idea uses. Could you please release 1.23 so I could replace this patched version with new unpatched one. We have couple bugs for which we need logging which was added in 1.22 and so we need to update the lib anyway and it would be better to do it once (and w/o patching)

[oleg-nenashev]

@os97673
The release has been slightly delayed due to #16
The new version has been released on Maven Central => it should become available soon

[os97673]

@oleg-nenashev great news, thanks.