Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration of logging handlers to log4net (#69) #73

Merged
merged 1 commit into from
Feb 2, 2015
Merged

Migration of logging handlers to log4net (#69) #73

merged 1 commit into from
Feb 2, 2015

Conversation

oleg-nenashev
Copy link
Member

DONE:

  • Integrate log4net into WinSW, migrate wrapper.log engine

TODOs:

  • Migrate EventLogs to log4net
  • Delegate exceptions handling to log4net
  • Allows setting up log levels from ServiceDescriptor
  • (?) Migrate STDERR/STDOUT logs to log4net
  • (?) Support XML configurations of log4net loggers

Signed-off-by: Oleg Nenashev o.v.nenashev@gmail.com

@oleg-nenashev oleg-nenashev added this to the winsw-2.0 milestone Jan 31, 2015
@oleg-nenashev oleg-nenashev self-assigned this Jan 31, 2015
This was referenced Feb 1, 2015
Closed
Open
Open
Closed
oleg-nenashev
oleg-nenashev reviewed Feb 2, 2015
View reviewed changes
src/Core/ServiceWrapper/Main.cs
args[0] = args[0].ToLower();
if (args[0] == "install")
String command = args[0].ToLower();
if (command == "install")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution occasionally adds the refactoring of the commands handling.
It needs to be reworked to have a proper merge with https://github.com/kohsuke/winsw

@oleg-nenashev
Integrate log4net into WinSW, migrate wrapper.log engine
98268b2 
TODOs:
    Migrate EventLogs to log4net
    Delegate exceptions handling to log4net
    Allows setting up log levels from ServiceDescriptor
    (?) Migrate STDERR/STDOUT logs to log4net
    (?) Support XML configurations of log4net loggers

Related to winsw#69

Signed-off-by: Oleg Nenashev o.v.nenashev@gmail.com
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
@oleg-nenashev
Copy link
Member Author

Merging the basic logging to allow the usage of ServiceWrapper log in other branches.

oleg-nenashev added a commit that referenced this pull request Feb 2, 2015
@oleg-nenashev
Merge pull request #73 from oleg-nenashev/winsw-2.0-logging
11c98da 
Migration of logging handlers to log4net (#69)
@oleg-nenashev oleg-nenashev merged commit 11c98da into winsw:winsw-2.0 Feb 2, 2015
@oleg-nenashev oleg-nenashev mentioned this pull request Nov 25, 2016
Closed
3 tasks
@aminjam
Copy link

aminjam commented Apr 20, 2017

@oleg-nenashev We would like to enable sending all logs to Windows Event Viewer. Would Adding support for the above features Migrate STDERR/STDOUT logs to log4net and Support XML configurations of log4net loggers enable us to do that?

@oleg-nenashev
Copy link
Member Author

oleg-nenashev commented Apr 20, 2017 •
edited
Loading

@aminjam I doubt Support XML configurations of log4net loggers will be implemented in such way. #158 just addresses the minimal config.

log4net already allows configuring everything in exe.config file, hence you will be able to get this feature once #87 is integrated (likely via the logging=log4net mode).

@nxtn nxtn modified the milestones: winsw-2.0, 1.17, 2.0.0 Mar 25, 2020
@winsw winsw locked as resolved and limited conversation to collaborators Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@oleg-nenashev oleg-nenashev

Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oleg-nenashev @aminjam @nxtn