Vector Deque #5
Merged
Vector Deque #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWhiting
reviewed
Apr 22, 2024
added 3 commits
April 22, 2024 10:46
doc(deque): added documentation to deque.
TimWhiting
requested changes
Apr 22, 2024
Co-authored-by: Tim Whiting <tim@whitings.org>
TimWhiting
requested changes
Apr 22, 2024
Co-authored-by: Tim Whiting <tim@whitings.org>
I'll will change the API and add in an |
TimWhiting
approved these changes
Apr 23, 2024
TimWhiting
added a commit
that referenced
this pull request
Apr 23, 2024
--------- Co-authored-by: ki11errabbit <ki11errabbit@posteo.net> Co-authored-by: Tim Whiting <tim@whitings.org>
TimWhiting
added a commit
that referenced
this pull request
May 2, 2024
* fix: corrected size of a resized vector (#7) Co-authored-by: ki11errabbit <ki11errabbit@posteo.net> * Vector Deque (#5) --------- Co-authored-by: ki11errabbit <ki11errabbit@posteo.net> Co-authored-by: Tim Whiting <tim@whitings.org> * feat: working on min-max heap * feat: added delete-min and delete-max * feat: completed most of heap * fix: working on getting heap max working * feat: added swap function * fix: got heap working * fix: fixed insertion into heap * doc(heap): added documentation to heap * switch to cmp * improve names on a few things * fix: fixed logic, now just need to remove debug prints * fix: removed debug prints, but there are still errors * fix: fixed all noticed errors * fix: removed main from heap, fixed deque being mutable and made it immutable * fix: removed typo, and changed name of checks in get-next-* to indicate where in the family tree they are. * fix: made logic clearer in get-next-* * fix: fixed indentation of if then else, fixed merge error in core-extras --------- Co-authored-by: ki11errabbit <ki11errabbit@posteo.net> Co-authored-by: Tim Whiting <tim@whitings.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a double ended queue that is similar to the vector-list. I figured that since Rust's stdlib contained one, I might as well make one for this library.