Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrected size of a resized vector #7

Merged

Conversation

Ki11erRabbit
Copy link
Member

Here is a fix for vectors being truncated improperly.

Copy link
Member

@TimWhiting TimWhiting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@TimWhiting TimWhiting merged commit b101b26 into koka-community:main Apr 22, 2024
TimWhiting pushed a commit that referenced this pull request Apr 23, 2024
Co-authored-by: ki11errabbit <ki11errabbit@posteo.net>
TimWhiting added a commit that referenced this pull request May 2, 2024
* fix: corrected size of a resized vector (#7)

Co-authored-by: ki11errabbit <ki11errabbit@posteo.net>

* Vector Deque (#5)

---------

Co-authored-by: ki11errabbit <ki11errabbit@posteo.net>
Co-authored-by: Tim Whiting <tim@whitings.org>

* feat: working on min-max heap

* feat: added delete-min and delete-max

* feat: completed most of heap

* fix: working on getting heap max working

* feat: added swap function

* fix: got heap working

* fix: fixed insertion into heap

* doc(heap): added documentation to heap

* switch to cmp

* improve names on a few things

* fix: fixed logic, now just need to remove debug prints

* fix: removed debug prints, but there are still errors

* fix: fixed all noticed errors

* fix: removed main from heap, fixed deque being mutable and made it immutable

* fix: removed typo, and changed name of checks in get-next-* to indicate where in the family tree they are.

* fix: made logic clearer in get-next-*

* fix: fixed indentation of if then else, fixed merge error in core-extras

---------

Co-authored-by: ki11errabbit <ki11errabbit@posteo.net>
Co-authored-by: Tim Whiting <tim@whitings.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants