Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sparse tests fail with floats on. #1362

Closed
jgfouca opened this issue Mar 14, 2022 · 4 comments
Closed

Some sparse tests fail with floats on. #1362

jgfouca opened this issue Mar 14, 2022 · 4 comments
Assignees

Comments

@jgfouca
Copy link
Contributor

jgfouca commented Mar 14, 2022

The following tests have been failing for a while:

[  FAILED  ] openmp.sparse_spmv_float_int_int_TestExecSpace
[  FAILED  ] openmp.sparse_spmv_float_int_size_t_TestExecSpace
[  FAILED  ] openmp.sparse_spmv_mv_float_int_int_LayoutLeft_TestExecSpace
[  FAILED  ] openmp.sparse_spmv_mv_float_int_size_t_LayoutLeft_TestExecSpace

I have tried to bisect, but the problem goes back more than a month and my kokkos-kernels repo quickly becomes incompatible with my kokkos installation. That raises an additional question: as you go back in history, is there any way to know what version of kokkos to use with kokkos-kernels?

I am using the following to configure kokkos:

cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DKokkos_ENABLE_OPENMP=ON -DKokkos_ENABLE_SERIAL=ON -DCMAKE_INSTALL_PREFIX=${HOME}/kokkos/install ..

And this to configure kokkos-kernels:

cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DKokkosKernels_INST_FLOAT=ON -DKokkosKernels_ENABLE_TESTS=ON -DKokkos_ROOT=${HOME}/kokkos/install ..

I have the follow modules loaded:

 1) sems-archive-env   2) sems-archive-gcc/9.2.0   3) sems-archive-cmake/3.19.1   4) sems-archive-git/2.10.1   5) sems-archive-openmpi/4.0.2   6) sems-archive-hdf5/1.10.6/parallel   7) sems-archive-netcdf/4.7.3/parallel

And ran my tests via:

OMP_NUM_THREADS=8 ./KokkosKernels_sparse_openmp

@lucbv , I assigned you since I thought you might know who to pass the ticket to.

@lucbv
Copy link
Contributor

lucbv commented May 19, 2022

Okay, hopefully PR #1412 fixed it, let me know if you see it again, otherwise we might be able to close this.

@ndellingwood
Copy link
Contributor

Was this resolved by #1412 ?

@lucbv
Copy link
Contributor

lucbv commented Mar 22, 2023

I think so but @jgfouca should probably confirm first.

@jgfouca
Copy link
Contributor Author

jgfouca commented Mar 22, 2023

@lucbv , @ndellingwood , yep, appears to work now! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants