-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Necessity of both KokkosKernels_ENABLED_COMPONENTS
and KokkosKernels_ENABLE_...
?
#2071
Comments
I think It probably makes more sense for this code to be reworked to check the |
Any insight re the Trilinos integration @ndellingwood? |
@cwpearson so the options were originally named as you posted (i.e. KokkosKernels_ENABLE_BLAS etc), but in Trilinos builds there was some TriBITs variable naming and interaction that overlapped with the KokkosKernels naming but occurred prior to processing of the KokkosKernels_ENABLE_{Component} macros, in particular this resulted in enable of |
Here is cross-reference to the PR with the renaming of the options to workaround the overload/naming collision with TriBITS: #1641 |
@cwpearson my first read of the question may have been a misinterpretation - you're talking specifically about |
Documentation-wise, we do need to update https://github.com/kokkos/kokkos-kernels/wiki/Building#component-options for the individual components |
We have this guy:
And also these guys:
The text was updated successfully, but these errors were encountered: