Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYCL/PVC: native spmv, spmv_mv fail for complex_double #2127

Open
brian-kelley opened this issue Mar 1, 2024 · 0 comments
Open

SYCL/PVC: native spmv, spmv_mv fail for complex_double #2127

brian-kelley opened this issue Mar 1, 2024 · 0 comments
Labels

Comments

@brian-kelley
Copy link
Contributor

brian-kelley commented Mar 1, 2024

With this configuration on blake's PVC node, spmv and spmv_mv unit tests for complex_double fail due to incorrect results.

../kokkos-kernels/cm_generate_makefile.bash \
        --with-devices=sycl \
        --arch=INTEL_PVC \
        --with-scalars=float,double,complex_float,complex_double \
        --with-layouts=LayoutLeft \
        --with-ordinals=int \
        --with-offsets=int \
        --shared \
        --release --kokkos-release \
        --cxxflags="-fno-finite-math-only"

The other 3 scalar types are OK. This isn't a tolerance issue. The values that are wrong are way off, but some values are correct...

./KokkosKernels_sparse_sycl
[==========] 20 tests from 1 test case ran. (386330 ms total)
[  PASSED  ] 16 tests.
[  FAILED  ] 4 tests, listed below:
[  FAILED  ] sycl_test.sparse_spmv_kokkos_complex_double_int_int_TestDevice
[  FAILED  ] sycl_test.sparse_spmv_kokkos_complex_double_int_size_t_TestDevice
[  FAILED  ] sycl_test.sparse_spmv_mv_kokkos_complex_double_int_int_LayoutLeft_TestDevice
[  FAILED  ] sycl_test.sparse_spmv_mv_kokkos_complex_double_int_size_t_LayoutLeft_TestDevice

./KokkosKernels_blocksparse_sycl
[==========] 28 tests from 1 test case ran. (85255 ms total)
[  PASSED  ] 20 tests.
[  FAILED  ] 8 tests, listed below:
[  FAILED  ] sycl_test.sparse_block_spgemm_double_int_int_TestDevice
[  FAILED  ] sycl_test.sparse_block_spgemm_double_int_size_t_TestDevice
[  FAILED  ] sycl_test.sparse_block_spgemm_kokkos_complex_double_int_int_TestDevice
[  FAILED  ] sycl_test.sparse_block_spgemm_kokkos_complex_double_int_size_t_TestDevice
[  FAILED  ] sycl_test.sparse_bsr_spmv_kokkos_complex_double_int_int_TestDevice
[  FAILED  ] sycl_test.sparse_bsr_spmv_kokkos_complex_double_int_size_t_TestDevice
[  FAILED  ] sycl_test.sparse_bsr_spmmv_kokkos_complex_double_int_int_LayoutLeft_TestDevice
[  FAILED  ] sycl_test.sparse_bsr_spmmv_kokkos_complex_double_int_size_t_LayoutLeft_TestDevice

(the spgemm failures already have an issue open)

#2128 reports that spmv_mv for complex double also fails for sapphire rapids with intel 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant