Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: KokkosKernels_default_types.hpp missing namespace #2335

Closed
maartenarnst opened this issue Sep 11, 2024 · 1 comment
Closed

common: KokkosKernels_default_types.hpp missing namespace #2335

maartenarnst opened this issue Sep 11, 2024 · 1 comment

Comments

@maartenarnst
Copy link

The file common/src/KokkosKernels_default_types.hpp defines various type aliases for use across kokkos-kernels. However, this file is missing a namespace, so that these type alias are made in the global scope.

This issue is thus a suggestion to consider introducing a namespace for the default types. A namespace named e.g. KokkosKernels or KokkosKernels::Impl may work, and such a name may limit the changes that may need to be done in the rest of the code.

@maartenarnst
Copy link
Author

OK! Thanks @cwpearson !

Also tagging @romintomasetti.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants